Add s3 url config by githubzilla · Pull Request #366 · eloqdata/eloqdoc

githubzilla · 2025-12-12T08:56:23Z

Summary by CodeRabbit

Chores
- Broadened ignore rules to cover all variants of compile commands and added IDE cursor-related entries to ignore lists.
- Updated an internal submodule pointer; this dependency update is non-functional and introduces no user-facing behavior changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-12T08:56:40Z

Walkthrough

Broadened .gitignore to compile_commands*, added .cursor and thoughts ignore entries, and advanced the src/mongo/db/modules/eloq/data_substrate submodule pointer to a new commit hash.

Changes

Cohort / File(s)	Change Summary
Build configuration `\.gitignore`	Replaced `compile_commands.json` with `compile_commands*`; added `.cursor` and `thoughts` ignore entries.
Submodule pointer `src/mongo/db/modules/eloq/data_substrate`	Updated submodule commit pointer from `44c32ca3e94c3a382cea2d72b86443e1015c8372` to `afe9672a042e52021815f95db9dc16815afb9ea4` (pointer-only change).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Review focus:
- Ensure compile_commands* doesn't unintentionally match and ignore needed files.
- Confirm the new submodule commit is intentional and accessible.

Possibly related PRs

update submoulde #375 — Also updates the src/mongo/db/modules/eloq/data_substrate submodule pointer to a different commit.
update submodule #341 — Updates the same submodule pointer to another commit target.

Suggested reviewers

lzxddz

Poem

🐰 I nibbled whitespace, hopped the tree,

compile_commands now let variants be,
Cursor crumbs and thoughts tucked out of sight,
The submodule leapt to a fresher night,
Tiny hops — everything feels light.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'Add s3 url config' does not match the actual changes, which only involve .gitignore updates and a submodule pointer update with no S3 URL configuration changes.	Update the title to accurately reflect the changes, such as 'Update .gitignore and submodule pointer' or 'Ignore Cursor IDE files and update eloq submodule'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef3079b and 3ebe2c6.

📒 Files selected for processing (2)

.gitignore (2 hunks)
src/mongo/db/modules/eloq/data_substrate (1 hunks)

✅ Files skipped from review due to trivial changes (1)

src/mongo/db/modules/eloq/data_substrate

🚧 Files skipped from review as they are similar to previous changes (1)

.gitignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.gitignore (1)
12-12: Remove the * ignore rule — it will ignore the entire repository.
With * present, Git will treat all paths as ignored unless explicitly re-included via ! rules, which is almost never desired for a repo .gitignore.
-*

🧹 Nitpick comments (1)

.gitignore (1)
189-192: Scope thoughts ignore; it’s too generic as-is.
Ignoring thoughts anywhere in the tree can accidentally hide real project content. Prefer anchoring it (repo root) or scoping it under .cursor if that’s the intent.
 # cursor ide
 .cursor
-thoughts
+/thoughts
+# or, if this is Cursor-specific:
+# /.cursor/thoughts

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83690ed and 33de17b.

📒 Files selected for processing (2)

.gitignore (2 hunks)
src/mongo/db/modules/eloq/data_substrate (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-11-28T10:55:21.020Z

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

src/mongo/db/modules/eloq/data_substrate

🔇 Additional comments (2)

src/mongo/db/modules/eloq/data_substrate (1)

1-1: Submodule pointer update requires verification of private repository changes and S3 config integration.

The parent repo's required CMake options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, STATISTICS) are still defined in src/mongo/db/modules/eloq/CMakeLists.txt (lines 20–22), so the superproject's build interface is intact. However, commit abc7dc3a3d4b03e4ce14e729eb0f6c85c0e80b51 in the private tx_service submodule cannot be inspected in this environment to confirm the intended S3 URL config changes or verify that the submodule still honors those options. Ensure the submodule build system continues to accept these configuration flags and that any new S3 URL handling is compatible with the parent build pipeline.

.gitignore (1)

166-166: compile_commands* pattern is safe.
No tracked files in the repository match this pattern, confirming it will only ignore build artifact variants like compile_commands.json without affecting any committed files.

githubzilla added the trigger-ci label Dec 12, 2025

coderabbitai bot reviewed Dec 12, 2025

View reviewed changes

githubzilla mentioned this pull request Dec 12, 2025

Support s3_url for store_handler and txlog #262

Closed

githubzilla force-pushed the add_s3_url_config branch from c00d69f to 9849a63 Compare December 16, 2025 10:44

githubzilla added 2 commits December 18, 2025 12:35

Ass cursor and compile_command to gitignore

785ee2d

Updata data_substrate

3ebe2c6

githubzilla force-pushed the add_s3_url_config branch from ef3079b to 3ebe2c6 Compare December 18, 2025 04:36

githubzilla requested a review from liunyl December 18, 2025 04:58

liunyl approved these changes Dec 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add s3 url config#366

Add s3 url config#366
githubzilla wants to merge 2 commits intoeloqdata:mainfrom
githubzilla:add_s3_url_config

githubzilla commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

githubzilla commented Dec 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

githubzilla commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 12, 2025 •

edited

Loading